linux-kernel - Re: [PATCH] sparc64: use unsigned long long for u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081227.005452.261413194.davem@davemloft.net>
Date:	Sat, 27 Dec 2008 00:54:52 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	sam@...nborg.org
Cc:	akpm@...ux-foundation.org, sparclinux@...r.kernel.org,
	mingo@...e.hu, sfr@...b.auug.org.au, linux-kernel@...r.kernel.org,
	kenchen@...gle.com, paulus@...ba.org, tglx@...utronix.de,
	hpa@...or.com, linux-next@...r.kernel.org
Subject: Re: [PATCH] sparc64: use unsigned long long for u64

From: Sam Ravnborg <sam@...nborg.org>
Date: Tue, 23 Dec 2008 14:17:46 +0100

> It may take a few days before the drivers gets fixed.
> Christmas is approaching fast by now.

Even with this and your driver patch applied, the tree
doesn't build successfully:

cc1: warnings being treated as errors
arch/sparc/kernel/psycho_common.c: In function ‘psycho_check_stc_error’:
arch/sparc/kernel/psycho_common.c:104: warning: format ‘%016lx’ expects type ‘long unsigned int’, but argument 4 has type ‘long long unsigned int’

Did you remove sparc's -Werror when doing test builds
of these changes? :-)

Either way these need some work before they should be
added to any tree.

Andrew you probably want to toss these from your tree
since at a minimum they will break the sparc64 build.

Sam will fix them up and resubmit, and I'll apply them,
don't worry. :)