linux-kernel - Re: [PATCH] x86: reboot.c declare port_cf9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081227103141.GF14639@elte.hu>
Date:	Sat, 27 Dec 2008 11:31:41 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh <jaswinder@...radead.org>
Cc:	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get
	used


* Jaswinder Singh <jaswinder@...radead.org> wrote:

> Impact: cleanup, avoid sparse warning
> 
> Include "../pci/pci.h" for port_cf9_safe
> 
> Fixes this sparse warning:
> arch/x86/kernel/reboot.c:43:6: warning: symbol 'port_cf9_safe' was not declared. Should it be static?
> 
> Signed-off-by: Jaswinder Singh <jaswinder@...radead.org>
> ---
>  arch/x86/kernel/reboot.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

applied to tip/x86/cleanups, thanks!

btw., this is ugly now:

> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -22,6 +22,7 @@
>  #endif
>  
>  #include <mach_ipi.h>
> +#include "../pci/pci.h"

could you send another patch that moves arch/x86/pci/pci.h to 
arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/