linux-kernel - Re: nbd: clean up error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081228080330.GB1600@ucw.cz>
Date:	Sun, 28 Dec 2008 09:03:30 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	Paul Clements <paul.clements@...eleye.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: nbd: clean up error handling

On Thu 2008-12-18 14:15:39, Paul Clements wrote:
> Hi Pavel,
>
> hanks for the patch...
>
> Pavel Machek wrote:
>> Uses existing error_out: label instead of hardcoding error action.
>>
>> Signed-off-by: Pavel Machek <pavel@...e.cz>
>
>> @@ -475,8 +473,7 @@ static void nbd_handle_req(struct nbd_de
>>  	if (nbd_send_req(lo, req) != 0) {
>>  		printk(KERN_ERR "%s: Request send failed\n",
>>  				lo->disk->disk_name);
>> -		req->errors++;
>> -		nbd_end_request(req);
>> +		goto error_out;
>
> This one is not correct. We don't return immediately here.

Sorry about that. Will do next series shortly...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/