linux-kernel - Re: [git pull] sparseirq / irq updates for v2.6.29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081229110954.GB5065@elte.hu>
Date:	Mon, 29 Dec 2008 12:09:54 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Yinghai Lu <yhlu.kernel@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Subject: Re: [git pull] sparseirq / irq updates for v2.6.29


* KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com> wrote:

> >>  kernel/irq/handle.c |    5 -----
> >>  kernel/irq/manage.c |    9 +++++++++
> >>  2 files changed, 9 insertions(+), 5 deletions(-)
> >>
> >
> > that is not enough.
> >
> > please check
> >
> > need one printk, and move two functions into chip.c
> 
> I'm sad ;-)
> 
> Why you use printk? if develper use non-x86 machine, they will see 
> perfectly worthless debug messages...

yes. If you can reproduce the problem then please check the version in 
tip/master:

  http://people.redhat.com/mingo/tip.git/README

it doesnt include any needless printks.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/