linux-kernel - Re: [PATCH] ide: Fix drive's DWORD-IO handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 29 Dec 2008 19:47:52 +0100
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Mario Schwalbe <schwalbe@....tu-dresden.de>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Sergei Shtylyov <sshtylyov@...mvista.com>
Subject: Re: [PATCH] ide: Fix drive's DWORD-IO handling

On Friday 19 December 2008, Bartlomiej Zolnierkiewicz wrote:
> On Thursday 18 December 2008, Mario Schwalbe wrote:
> > Resubmitted on request.
> > 
> > According the documentation, id[ATA_ID_DWORD_IO] is non-zero if
> > the drive supports dword IO, while the code disables support by
> > setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been
> > reused by the ATA8 specification. This patch fixes both cases.
> > 
> > Signed-off-by: Mario Schwalbe <schwalbe@....tu-dresden.de>
> > ---
> >  drivers/ide/ide-probe.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/ide/ide-probe.c b/drivers/ide/ide-probe.c
> > index c55bdbd..859b0e5 100644
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> > @@ -856,7 +856,7 @@ static void ide_port_tune_devices(ide_hwif_t *hwif)
> >  		ide_drive_t *drive = &hwif->drives[unit];
> > 
> >  		if ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||
> > -		    drive->id[ATA_ID_DWORD_IO])
> > +		    !ata_id_has_dword_io(drive->id))
> >  			drive->dev_flags |= IDE_DFLAG_NO_IO_32BIT;
> >  		else
> >  			drive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;
> 
> Since it seems that libata developers need more time to fully analyze
> issues with ata_id_has_dword_io() and I don't want to delay this fix
> because if it could you please modify the patch according to Sergei's
> suggestion of removing id[ATA_ID_DWORD_IO] check altogether?
> 
> [ It is a safe thing to do since the old code has been enabling 32-bit
>   I/O _unless_ the ATA-1 dword I/O bit for VU compatibility was set... ]

I merged the patch and did the modification while at it:

From: Mario Schwalbe <schwalbe@....tu-dresden.de>
Subject: [PATCH] ide: Fix drive's DWORD-IO handling

According the documentation, id[ATA_ID_DWORD_IO] is non-zero if
the drive supports dword IO, while the code disables support by
setting IDE_DFLAG_NO_IO_32BIT. In addition, this word has been
reused by the ATA8 specification. This patch fixes both cases.

Signed-off-by: Mario Schwalbe <schwalbe@....tu-dresden.de>
Cc: Sergei Shtylyov <sshtylyov@...mvista.com>
[bart: remove id[ATA_ID_DWORD_IO] check altogether per Sergei's suggestion]
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
 drivers/ide/ide-probe.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Index: b/drivers/ide/ide-probe.c
===================================================================
--- a/drivers/ide/ide-probe.c
+++ b/drivers/ide/ide-probe.c
@@ -849,8 +849,7 @@ static void ide_port_tune_devices(ide_hw
 	}
 
 	ide_port_for_each_dev(i, drive, hwif) {
-		if ((hwif->host_flags & IDE_HFLAG_NO_IO_32BIT) ||
-		    drive->id[ATA_ID_DWORD_IO])
+		if (hwif->host_flags & IDE_HFLAG_NO_IO_32BIT)
 			drive->dev_flags |= IDE_DFLAG_NO_IO_32BIT;
 		else
 			drive->dev_flags &= ~IDE_DFLAG_NO_IO_32BIT;
.