linux-kernel - Re: [PATCH 3/3] kmemtrace: Use tracepoints instead of markers.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081229201129.GA5386@localhost>
Date:	Mon, 29 Dec 2008 22:11:29 +0200
From:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] kmemtrace: Use tracepoints instead of markers.

On Mon, Dec 29, 2008 at 03:43:56PM +0200, Pekka Enberg wrote:
> Hi Eduard,
> 
> On Mon, 2008-12-29 at 03:40 +0200, Eduard - Gabriel Munteanu wrote:
> > diff --git a/mm/slab.c b/mm/slab.c
> > index 1fcb32b..74d405d 100644
> > --- a/mm/slab.c
> > +++ b/mm/slab.c
> > @@ -3624,8 +3624,9 @@ void *kmem_cache_alloc(struct kmem_cache *cachep, gfp_t flags)
> >  {
> >  	void *ret = __cache_alloc(cachep, flags, __builtin_return_address(0));
> >  
> > -	kmemtrace_mark_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> > -			     obj_size(cachep), cachep->buffer_size, flags);
> > +	trace_kmemtrace_alloc(KMEMTRACE_TYPE_CACHE, _RET_IP_, ret,
> > +			      obj_size(cachep), cachep->buffer_size,
> > +			      flags, -1);
> 
> One minor nit: I'd prefer we call these trace_kmem_cache_alloc(),
> trace_kmalloc(), and so on. The trace_kmemtrace prefix doesn't really
> make much sense to me.

Sure, I'll also move the KMEMTRACE_TYPE_* enum to mm/kmemtrace.c.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/