linux-kernel - Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812291602.18572.vapier@gentoo.org>
Date:	Mon, 29 Dec 2008 16:02:16 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Adrian McMenamin <adrian@...golddream.dyndns.info>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-sh" <linux-sh@...r.kernel.org>,
	"linux-input" <linux-input@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast

On Monday 29 December 2008 14:17:25 Adrian McMenamin wrote:
> +static int __devinit probe_maple_mouse(struct device *dev)
> +static int remove_maple_mouse(struct device *dev)

i thought you were going the rout of not labeling any of the probe/remove 
functions ... but if you label the prob with __devinit, then the remove should 
be __devexit.  i.e. whichever way you go, the two should be consistent.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)