linux-kernel - Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081229100746.GA12159@elte.hu>
Date:	Mon, 29 Dec 2008 11:07:46 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...radead.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>, mj@....cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to
	arch/x86/include/asm/pci_x86.h


* Jaswinder Singh Rajput <jaswinder@...radead.org> wrote:

> On Mon, 2008-12-29 at 09:57 +0300, Alexey Dobriyan wrote:
> > On Sat, Dec 27, 2008 at 06:32:28PM +0530, Jaswinder Singh Rajput wrote:
> > > Impact: cleanup, arch/x86/pci/pci.h -> arch/x86/include/asm/pci_x86.h
> > 
> > And this is done for what?
> 
> Don't you think arch/x86/pci/pci.h looks ugly it should be in
> arch/x86/incluse/asm directory ?
> 
> It was suggested by Ingo :
> http://marc.info/?l=linux-kernel&m=123037395221921&w=2
> 
> I think Ingo will have more valid reasons to satisfy your curiousity ;-)

yes - the reason why i asked for that is that asm/pci.h already exists, 
and it is included in generic code (via linux/include/pci.h) and provides 
public PCI interfaces.

pci_x86.h (a'ka arch/x86/pci/pci.h) includes lowlevel x86-only internals, 
included from a handful PCI arch/x86/ platform .c files.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/