linux-kernel - Re: [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in af9005_usb_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081230194000.GA7420@localhost>
Date:	Tue, 30 Dec 2008 22:40:00 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-dvb-maintainer@...uxtv.org,
	video4linux-list@...hat.com, linux-kernel@...r.kernel.org,
	Patrick Boettcher <patrick.boettcher@...y.de>
Subject: Re: [GIT PATCHES for 2.6.28] V4L/DVB fixes, crash in
	af9005_usb_module_init()

[Mauro Carvalho Chehab - Tue, Dec 30, 2008 at 05:33:10PM -0200]
| 
| On Sat, 27 Dec 2008 20:11:22 +0300
| Cyrill Gorcunov <gorcunov@...il.com> wrote:
| 
| > [Ingo Molnar - Sat, Dec 27, 2008 at 05:40:20PM +0100]
| > | 
| > | * Ingo Molnar <mingo@...e.hu> wrote:
| > | 
| > | > [...] I have re-enabled the driver in tip/master [...]
| > | 
| > | ok, just got this build failure:
| > | 
| > |  drivers/built-in.o: In function `dm1105_probe':
| > |  dm1105.c:(.devinit.text+0x2298b): undefined reference to `cx24116_attach'
| > |  make: *** [.tmp_vmlinux1] Error 1
| > | 
| > | config attached. Can test any fix patch.
| > | 
| > | 	Ingo
| > |
| > 
| > Something like that?
| 
| I suspect that this will work. Could you please send your SOB?
| 

Without problem :)

---
Subject: [PATCH] DVB: cx24116 - build fix

Add missed MODULE check to eliminate inapropriate
declaration being choosed which causes a build error.

Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
---

 drivers/media/dvb/frontends/cx24116.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.git/drivers/media/dvb/frontends/cx24116.h
===================================================================
--- linux-2.6.git.orig/drivers/media/dvb/frontends/cx24116.h
+++ linux-2.6.git/drivers/media/dvb/frontends/cx24116.h
@@ -37,7 +37,8 @@ struct cx24116_config {
 	u8 mpg_clk_pos_pol:0x02;
 };
 
-#if defined(CONFIG_DVB_CX24116) || defined(CONFIG_DVB_CX24116_MODULE)
+#if defined(CONFIG_DVB_CX24116) || \
+	(defined(CONFIG_DVB_CX24116_MODULE) && defined(MODULE))
 extern struct dvb_frontend *cx24116_attach(
 	const struct cx24116_config *config,
 	struct i2c_adapter *i2c);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/