linux-kernel - RE: [PATCH 3/7] drivers/message/fusion: Move a dereference below a NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B73941C4DE6A3D4EA1AE128E9565E2442392552FDF@inbmail01.lsi.com>
Date:	Tue, 30 Dec 2008 09:50:29 +0530
From:	"Prakash, Sathya" <Sathya.Prakash@....com>
To:	Julia Lawall <julia@...u.dk>, "Moore, Eric" <Eric.Moore@....com>,
	"Support, Software" <support@....com>,
	DL-MPT Fusion Linux <DL-MPTFusionLinux@....com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH 3/7] drivers/message/fusion: Move a dereference below a
 NULL test

ACK.

-----Original Message-----
From: Julia Lawall [mailto:julia@...u.dk]
Sent: Friday, December 26, 2008 12:58 PM
To: Moore, Eric; Support, Software; DL-MPT Fusion Linux; linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-janitors@...r.kernel.org
Subject: [PATCH 3/7] drivers/message/fusion: Move a dereference below a NULL test

From: Julia Lawall <julia@...u.dk>

If the NULL test is necessary, then the dereference should be moved below the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/).

// <smpl>
@disable is_null@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (E == NULL) S
  f(...,E->fld,...);
- if (E == NULL) S

@@
identifier f;
expression E;
identifier fld;
statement S;
@@

+ if (!E) S
  f(...,E->fld,...);
- if (!E) S
// </smpl>

Signed-off-by: Julia Lawall <julia@...u.dk>

---
 drivers/message/fusion/mptctl.c     |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c index b89f476..c638171 100644
--- a/drivers/message/fusion/mptctl.c
+++ b/drivers/message/fusion/mptctl.c
@@ -308,10 +308,11 @@ static void mptctl_timeout_expired (MPT_IOCTL *ioctl)  {
        int rc = 1;

-       dctlprintk(ioctl->ioc, printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n",
-                               ioctl->ioc->name, ioctl->ioc->id));
        if (ioctl == NULL)
                return;
+       dctlprintk(ioctl->ioc,
+                  printk(MYIOC_s_DEBUG_FMT ": Timeout Expired! Host %d\n",
+                  ioctl->ioc->name, ioctl->ioc->id));

        ioctl->wait_done = 0;
        if (ioctl->reset & MPTCTL_RESET_OK)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/