linux-kernel - Re: [PATCH] futex: add WARN_ON to catch certain assymetric (get|put)_futex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081230054257.GC11037@elte.hu>
Date:	Tue, 30 Dec 2008 06:42:57 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Darren Hart <dvhltc@...ibm.com>
Cc:	linux-kernel@...r.kernel.org,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rusty Russell <rusty@....ibm.com>
Subject: Re: [PATCH] futex: add WARN_ON to catch certain assymetric
	(get|put)_futex_key calls


* Darren Hart <dvhltc@...ibm.com> wrote:

> Following up on my previous key reference accounting patches, this patch
> will catch puts on keys that haven't been "got".  This won't catch nested
> get/put mismatches though.
> 
> Build and boot tested, with minimal desktop activity and a run of the
> open_posix_testsuite in LTP for testing.  No warnings logged.
> 
> Signed-off-by: Darren Hart <dvhltc@...ibm.com>
> Cc: "Peter Zijlstra" <peterz@...radead.org>
> Cc: "Thomas Gleixner" <tglx@...utronix.de>
> Cc: "Rusty Russell" <rusty@....ibm.com>
> ---
> 
>  kernel/futex.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)

applied to tip/core/futexes, thanks!

I changed this:

> +		WARN_ON(1);
>  		return;

to WARN_ON_ONCE() - warning once per bootup is good enough for 
kerneloops.org to pick it up, while a ton of warnings add no extra (other 
than to inconvenience the user, or even make the system unworkable).

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/