linux-kernel - Re: [PATCH] sched: sched.c declare variables before they get used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081230064316.GB30975@elte.hu>
Date:	Tue, 30 Dec 2008 07:43:16 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched: sched.c declare variables before they get used


* Jaswinder Singh Rajput <jaswinder@...radead.org> wrote:

> Impact: cleanup, avoid sparse warnings
> 
> In linux/sched.h moved out sysctl_sched_latency, 
> sysctl_sched_min_granularity, sysctl_sched_wakeup_granularity, 
> sysctl_sched_shares_ratelimit and sysctl_sched_shares_thresh from #ifdef 
> CONFIG_SCHED_DEBUG as these variables are common for both.
> 
> Fixes these sparse warnings:
> kernel/sched.c:825:14: warning: symbol 'sysctl_sched_shares_ratelimit' was not declared. Should it be static?
> kernel/sched.c:832:14: warning: symbol 'sysctl_sched_shares_thresh' was not declared. Should it be static?
> kernel/sched_fair.c:37:14: warning: symbol 'sysctl_sched_latency' was not declared. Should it be static?
> kernel/sched_fair.c:43:14: warning: symbol 'sysctl_sched_min_granularity' was not declared. Should it be static?
> kernel/sched_fair.c:72:14: warning: symbol 'sysctl_sched_wakeup_granularity' was not declared. Should it be static?
> 
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> ---
>  include/linux/sched.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

applied to tip/sched/cleanups, thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/