linux-kernel - Re: [PATCH 1/2] RCU: Don't include unnecessary headers, allow kmemtrace w/ tracepoints.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081230075337.GA9594@elte.hu>
Date:	Tue, 30 Dec 2008 08:53:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] RCU: Don't include unnecessary headers, allow
	kmemtrace w/ tracepoints.


* Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro> wrote:
> 
> > linux/percpu.h includes linux/slab.h, which generates circular inclusion
> > dependencies when trying to switch kmemtrace to use tracepoints instead
> > of markers. This patch allows tracing within slab headers' inline
> > functions.
> > 
> > Signed-off-by: Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
> > ---
> >  include/linux/rcuclassic.h |    1 -
> >  include/linux/rcupdate.h   |    1 -
> >  include/linux/rcupreempt.h |    2 +-
> >  3 files changed, 1 insertions(+), 3 deletions(-)
> 
> applied to tip/core/rcu, thanks Eduard!
> 
> I'll do some build coverage testing to see whether there's anything that 
> assumes the presence of percpu.h.

hm, there are quite a few such dependencies it appears, for example:

In file included from init/do_mounts_initrd.c:4:
include/linux/fs.h: In function 'alloc_secdata':
include/linux/fs.h:2214: error: implicit declaration of function 'get_zeroed_page'
include/linux/fs.h:2214: error: 'GFP_KERNEL' undeclared (first use in this function)
include/linux/fs.h:2214: error: (Each undeclared identifier is reported only once
include/linux/fs.h:2214: error: for each function it appears in.)
include/linux/fs.h: In function 'free_secdata':
include/linux/fs.h:2219: error: implicit declaration of function 
'free_page'
In file included from include/linux/slab.h:13,
                 from include/linux/percpu.h:6,
                 from include/linux/percpu_counter.h:14,
                 from include/linux/ext2_fs_sb.h:21,
                 from include/linux/ext2_fs.h:70,
                 from init/do_mounts_initrd.c:6:

config attached.

	Ingo

View attachment "config" of type "text/plain" (65905 bytes)