linux-kernel - Re: [PATCH 1/2] RCU: Don't include unnecessary headers, allow kmemtrace w/ tracepoints.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081230082153.GB17629@elte.hu>
Date:	Tue, 30 Dec 2008 09:21:53 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Cc:	Pekka Enberg <penberg@...helsinki.fi>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] RCU: Don't include unnecessary headers, allow
	kmemtrace w/ tracepoints.


* Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro> wrote:

> On Tue, Dec 30, 2008 at 08:53:37AM +0100, Ingo Molnar wrote:
> > hm, there are quite a few such dependencies it appears, for example:
> > 
> > In file included from init/do_mounts_initrd.c:4:
> > include/linux/fs.h: In function 'alloc_secdata':
> > include/linux/fs.h:2214: error: implicit declaration of function 'get_zeroed_page'
> > include/linux/fs.h:2214: error: 'GFP_KERNEL' undeclared (first use in this function)
> > include/linux/fs.h:2214: error: (Each undeclared identifier is reported only once
> > include/linux/fs.h:2214: error: for each function it appears in.)
> > include/linux/fs.h: In function 'free_secdata':
> > include/linux/fs.h:2219: error: implicit declaration of function 
> > 'free_page'
> > In file included from include/linux/slab.h:13,
> >                  from include/linux/percpu.h:6,
> >                  from include/linux/percpu_counter.h:14,
> >                  from include/linux/ext2_fs_sb.h:21,
> >                  from include/linux/ext2_fs.h:70,
> >                  from init/do_mounts_initrd.c:6:
> > 
> > config attached.
> > 
> > 	Ingo
> 
> Hm, that's weird, I was also testing on a 2.6.28-based tree. And I don't 
> see any reference to RCU headers in this error message. My guess is some 
> code assumes a certain header provides some definitions it isn't 
> required to.
> 
> I'll checkout your tree and have a look.

note: you'll need to apply your patch ontop of tip/master, i moved it out 
of tip/master for now due to the build breakage. Let me know if you cannot 
reproduce the problem, i'll then figure out what's going on.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/