linux-kernel - Re: [PATCH] x86: cpuid.c fix style problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020812310501w4c64de85r9125cfacccc5ae97@mail.gmail.com>
Date:	Wed, 31 Dec 2008 15:01:22 +0200
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Jaswinder Singh Rajput" <jaswinder@...radead.org>
Cc:	"Ingo Molnar" <mingo@...e.hu>, hpa@...nel.org,
	"x86 maintainers" <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: cpuid.c fix style problems

On Wed, Dec 31, 2008 at 12:59 PM, Jaswinder Singh Rajput
<jaswinder@...radead.org> wrote:
>        cpu = iminor(file->f_path.dentry->d_inode);
> -       if (cpu >= NR_CPUS || !cpu_online(cpu)) {
> +       if (cpu >= num_possible_cpus() || !cpu_online(cpu)) {

How come you didn't convert the first part of the expression to use
cpu_possible()?

>                ret = -ENXIO;   /* No such CPU */
>                goto out;
>        }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/