linux-kernel - Re: [PATCH] minix: fix add link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081231014923.GY28946@ZenIV.linux.org.uk>
Date:	Wed, 31 Dec 2008 01:49:23 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Nick Piggin <npiggin@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Evgeniy Dushistov <dushistov@...l.ru>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] minix: fix add link - wrong position calculation

On Wed, Dec 31, 2008 at 02:26:41AM +0100, Nick Piggin wrote:
> > commit 4a66af9eaa9531372cfcb9e20103ed147c729ff9
> > Author:     Nick Piggin <npiggin@...e.de>
> > AuthorDate: Tue Oct 16 01:25:21 2007 -0700
> > Commit:     Linus Torvalds <torvalds@...dy.linux-foundation.org>
> > CommitDate: Tue Oct 16 09:42:57 2007 -0700
> > 
> >     minixfs: convert to new aops
> > 
> > Is minixfs getting THAT little use, or is this bustage more subtle
> > than it appears?
> 
> Not getting used, I'd suspect (although I definitely have used it -- I
> converted it to large block size for testing fsblock, probably I didn't
> test softlinks).

Much simpler: there's one index for which the expressions are equivalent ;-)
Count how many entries does it take on minixfs to get to 4Kb.  Now think
how many had used that sucker on directories with >= 128 entries...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/