linux-kernel - Re: [PATCH 2/2] mmc_block: ensure all sectors that do not have errors are read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081231182135.57447238@mjolnir.drzeus.cx>
Date:	Wed, 31 Dec 2008 18:21:35 +0100
From:	Pierre Ossman <drzeus@...eus.cx>
To:	Adrian Hunter <ext-adrian.hunter@...ia.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mmc_block: ensure all sectors that do not have
 errors are read

On Mon, 22 Dec 2008 13:29:06 +0200
Adrian Hunter <ext-adrian.hunter@...ia.com> wrote:

> Pierre Ossman wrote:
> > 
> > Unfortunately, there is no guarantee that the sg list will be sector
> > aligned.
> 
> OK.  I am curious though - do you know anywhere in the kernel that actually
> does submit I/O in buffers that are not aligned to 512?
> 

Not really, no. Not that I've gone digging.

> 
> From: Adrian Hunter <ext-adrian.hunter@...ia.com>
> Subject: [PATCH] mmc_block: ensure all sectors that do not have errors are read
> 
> If a card encounters an ECC error while reading a sector it will
> timeout.  Instead of reporting the entire I/O request as having
> an error, redo the I/O one sector at a time so that all readable
> sectors are provided to the upper layers.
> 
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@...ia.com>
> ---

Queued up. Thanks for sticking through this somewhat long review
process. :)

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)