linux-kernel - Re: [PATCH] headers_check.pl: disallow extern's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200812311732.40076.vapier@gentoo.org>
Date:	Wed, 31 Dec 2008 17:32:32 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] headers_check.pl: disallow extern's

On Wednesday 31 December 2008 11:58:03 Arnd Bergmann wrote:
> On Saturday 27 December 2008, Mike Frysinger wrote:
> > +sub check_prototypes
> > +{
> > +	if ($line =~ m/^\s*extern\b/) {
> > +		printf STDERR "extern's make no sense in userspace\n";
> > +		$ret = 1;
> > +	}
> > +}
>
> Unfortunately, this way you can only detect prototypes with an explicit
> 'extern' in them, not the equivalent form with an implicit extern.
>
> Not sure if we can detect the other form reliably from perl.

yes, i already mentioned both of these issues.  that's why i suggested we 
start adding "extern" to all the headers (or at least the userspace ones).
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)