linux-kernel - Re: [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Jan 2009 02:32:32 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Duane Griffin <duaneg@...da.com>
Cc:	Evgeniy Dushistov <dushistov@...l.ru>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] ufs: don't truncate longer ufs2 fast symlinks

On Wed, Dec 31, 2008 at 04:50:06PM +0000, Duane Griffin wrote:
>  	} else {
> -		for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> +		for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
>  			ufsi->i_u1.i_symlink[i] = ufs2_inode->ui_u2.ui_symlink[i];

a) that probably ought to be a memcpy()
b) max len is superblock parameter and you've even validated it.  Why don't
you use it?

> -		for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4; i++)
> +		for (i = 0; i < (UFS_NDADDR + UFS_NINDIR) * 4 * 2; i++)
>  			ufs_inode->ui_u2.ui_symlink[i] = ufsi->i_u1.i_symlink[i];

Ditto.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/