linux-kernel - Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 1 Jan 2009 02:41:14 -0500
From:	Mike Frysinger <vapier@...too.org>
To:	Adrian McMenamin <adrian@...golddream.dyndns.info>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Sam Ravnborg <sam@...nborg.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-sh" <linux-sh@...r.kernel.org>,
	"linux-input" <linux-input@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [PATCH] sh: maple: add support for the Maple mouse on the SEGA Dreamcast

On Tuesday 30 December 2008 15:27:05 Adrian McMenamin wrote:
> Adding maple mouse with proper __devexit_p() handling

this kind of patch revision info typically goes below the --- marker and  the 
patch itself gets "v2", "v3", etc... header markers

otherwise, driver looks OK to me.  thanks for your dreamcast work.
Acked-by: Mike Frysinger <vapier@...too.org>

> +	mse = kzalloc(sizeof(struct dc_mouse), GFP_KERNEL);

personally i find this style less likely to rot:
mse = kzalloc(sizeof(*mse), GFP_KERNEL);
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (836 bytes)