lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f17812d70901011946p369bcd3bp8977405053cb6354@mail.gmail.com>
Date:	Fri, 2 Jan 2009 11:46:41 +0800
From:	"Eric Miao" <eric.y.miao@...il.com>
To:	"Mark Brown" <broonie@...ena.org.uk>
Cc:	"Samuel Ortiz" <sameo@...nedhand.com>,
	"Eric Miao" <eric.miao@...vell.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Fix section mismatch in da903x

Acked-by: Eric Miao <eric.miao@...vell.com>

Samuel, please help to merge.

On Thu, Jan 1, 2009 at 8:52 PM, Mark Brown <broonie@...ena.org.uk> wrote:
> The subdevice removal functions are marked __devexit but are referenced
> from the error handling path when probing so are needed even when
> __devexit functions are removed.
>
> Signed-off-by: Mark Brown <broonie@...ena.org.uk>
> ---
>  drivers/mfd/da903x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index 0b5bd85..248756f 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -435,13 +435,13 @@ static const struct i2c_device_id da903x_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, da903x_id_table);
>
> -static int __devexit __remove_subdev(struct device *dev, void *unused)
> +static int __remove_subdev(struct device *dev, void *unused)
>  {
>        platform_device_unregister(to_platform_device(dev));
>        return 0;
>  }
>
> -static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
> +static int da903x_remove_subdevs(struct da903x_chip *chip)
>  {
>        return device_for_each_child(chip->dev, NULL, __remove_subdev);
>  }
> --
> 1.5.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Cheers
- eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ