linux-kernel - Re: [PATCH 2/2] i8k: Add Dell Vostro systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090102184522.07bc2b86@slyfox.slynet.org>
Date:	Fri, 2 Jan 2009 18:45:22 +0200
From:	Sergei Trofimovich <slyfox@...ga.by>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] i8k: Add Dell Vostro systems

On Fri, 02 Jan 2009 16:19:23 +0000
Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

Hi! I bet, it does not pass checkpatch (tabs to spaces clash)
Sorry, can't send fixed patch.

> From: Federico Heinz <fheinz@...libre.org.ar>
> 
> This trivial patch adds support for i8k on the new Dell Vostro models.
> I tested it on my Vostro 1400, and it works. It does print a warning
> when loading the module:
> 
> 	i8k: unable to get SMM BIOS version
> 
> But I couldn't figure out how to fix that. The module seems to work fine,
> anyway...
> 
> Signed-off-by: Federico Heinz <fheinz@...libre.org.ar>
> Signed-off-by: Alan Cox <alan@...hat.com>
> ---
> 
>  drivers/char/i8k.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
> index 099fc89..fc8cf7a 100644
> --- a/drivers/char/i8k.c
> +++ b/drivers/char/i8k.c

...
> -	{ }
^^^^^^
This one
vvvvvvv
> +        { }
>  };

-- 

  Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/