linux-kernel - Re: [PATCH] kbuild: Disallow GCC 4.1.0 / 4.1.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 Jan 2009 18:57:37 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, David Miller <davem@...emloft.net>,
	akpm@...ux-foundation.org, rdreier@...co.com,
	ian.campbell@...rix.com, jeremy.fitzhardinge@...rix.com,
	deller@....de, rusty@...tcorp.com.au, linux-parisc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kyle@...artin.ca, randolph@...sq.org,
	dave@...uly1.hia.nrc.ca, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] kbuild: Disallow GCC 4.1.0 / 4.1.1

On Fri, Jan 02, 2009 at 09:38:14AM -0800, Linus Torvalds wrote:
> 
> 
> On Fri, 2 Jan 2009, Linus Torvalds wrote:
> > 
> > I think this is wrong.
> > 
> > Just move the check into <linux/compiler-gcc4.h>
> 
> In fact, looking at that whole mess, I redid it all. It was disgusting how 
> conditionals in gcc4.h needed to double-check that __GNUC__ really was 4 
> (rather than something bigger), which largely negated the whole nice clean 
> compiler version separation.
> 
> I pushed out my preferred version, which fixes up the whole thing. The 
> gcc4 header file now only gets included for __GNUC__ == 4, and when we 
> ever see a __GNUC__ of 5, it will automatically DTRT and try to include 
> <linux/compiler-gcc5.h> instead of #4.
> 
> And then the check in gcc4.h for 4.1.0 and 4.1.1 is much simplified.  The 
> two patches I pushed out add functionality, but don't actually add any new 
> lines (the first simplification patch removes more lines than it adds, and 
> the second one that adds the __weak bug test adds as mahy lines as the 
> cleanup removed).
> 
> And it all looks more logical too, imho.

Bugger....
Now I cannot do cross compile for: alpha, arm, m68k and sparc.

Not that I actually try to run these beasts but just being able
to do cross compile has served me well.

Last I looked (only few days ago) crosstool-ng did not support sparc :-(

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/