linux-kernel - Re: [patch] x86: Fix incorrect __read_mostly on _boot_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090102192058.GD14249@elte.hu>
Date:	Fri, 2 Jan 2009 20:20:58 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Ravikiran G Thirumalai <kiran@...lex86.org>
Cc:	linux-kernel@...r.kernel.org, travis@....com, stable@...nel.org,
	shai@...lex86.org
Subject: Re: [patch] x86: Fix incorrect __read_mostly on _boot_cpu_pda


* Ravikiran G Thirumalai <kiran@...lex86.org> wrote:

> On Fri, Jan 02, 2009 at 05:09:51PM +0100, Ingo Molnar wrote:
> >
> >* Ravikiran G Thirumalai <kiran@...lex86.org> wrote:
> >
> >> The pda rework (commit 3461b0af025251bbc6b3d56c821c6ac2de6f7209)
> >> to remove static boot cpu pdas introduced a bug.  _boot_cpu_pda is the
> >> actual pda used by the boot cpu and is definitely not "__read_mostly" and
> >> ended up polluting the read mostly section with writes.  This bug caused
> >> regression of about 8-10% on certain syscall intensive workloads.
> >> 
> >> Signed-off-by: Ravikiran Thirumalai <kiran@...lex86.org>
> >
> >applied to tip/x86/urgent, with a Cc: stable tag. Thanks,
> >
> 
> Thanks!
> 
> Stable maintainers, please consider this for 2.6.27 stable as well (in 
> addition to 28).  (Attaching the tip/x86/urgent commit as reference to 
> the patch)

i have added a -stable tag to the commit - please only put it into -stable 
once it hits Linus's tree. (in the next couple of days)

> 
	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/