linux-kernel - [PATCH] Missing v4l2_prio_close in radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 2 Jan 2009 06:41:00 +0100
From:	"Udo A. Steinberg" <udo@...ervisor.org>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	mchehab@...radead.org
Cc:	v4l-dvb-maintainer@...uxtv.org, video4linux-list@...hat.com
Subject: [PATCH] Missing v4l2_prio_close in radio_release

The radio_release function of the BTTV driver is missing a call to
v4l2_prio_close. As a result, after the radio device has been opened at
least once (e.g., by HAL during bootup), v4l2_priority will never drop below
V4L2_PRIORITY_INTERACTIVE again. With the following patch against 2.6.28,
applications that run with V4L2_PRIORITY_BACKGROUND are able to open devices
again. Previous Linux versions are affected as well.

Signed-off-by: Udo Steinberg <udo@...ervisor.org>

--- linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.c	2008-10-10 00:13:53.000000000 +0200
+++ linux-2.6.28/drivers/media/video/bt8xx/bttv-driver.new	2009-01-02 06:23:38.000000000 +0100
@@ -3473,6 +3474,7 @@
 	struct bttv *btv = fh->btv;
 	struct rds_command cmd;

+	v4l2_prio_close(&btv->prio,&fh->prio);
 	file->private_data = NULL;
 	kfree(fh);

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)