linux-kernel - Re: [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead of EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 02 Jan 2009 17:17:52 -0500 (EST)
From:	Len Brown <lenb@...nel.org>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-acpi@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [incremental-PATCH-for-Sam's-Review] ACPI: use ccflags-y instead
 of EXTRA_CFLAGS

> > --- a/drivers/acpi/Makefile
...
> > +ccflags-y			:= -Os

> The conversion from ACPI_CFLAGS to ccflags-y is fine.
> And if acpi really require -Os then this part is also OK -
> I just did not get *why* acpi needs -Os

ACPI does not "need" -Os.

However, ACPI in Linux has been built with -Os since 2.4
on the assumption that since ACPI should never be performance critical,
that it was best to simply have it consume as little space as possible.

It appears that the entire kernel is now built with -Os by default,
so it looks like this is now redundant in the default case and will
have an effect only when somebody disables CONFIG_CC_OPTIMIZE_FOR_SIZE
to build with -O2.

So I'm willing to delete -Os from the ACPI Makefile
in the interest of simplicity.

thanks,
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/