linux-kernel - Re: 2.6.28-git3 and i915 Kconfig new dependency on framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1230936608.6095.2.camel@gaiman.anholt.net>
Date:	Fri, 02 Jan 2009 14:50:08 -0800
From:	Eric Anholt <eric@...olt.net>
To:	Alessandro Suardi <alessandro.suardi@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.28-git3 and i915 Kconfig new dependency on framebuffer

On Wed, 2008-12-31 at 19:55 +0100, Alessandro Suardi wrote:
> make oldconfig from -git2 to -git3 doesn't build i915.ko unless
>  one has CONFIG_FB enabled; this causes /dev/dri/card0 to
>  be missing, and DRI disabled from within X.
> 
> Do I now (2.6.28-git3+) need CONFIG_FB to enable i915 DRM ?

Yes, the i915 driver now relies on fb code, though the new features are
runtime optional.  I may have noviced the Kconfig bits -- my intention
was "If you select I915, you also get all the CONFIG_FB-related bits
necessary".

config DRM_I915
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        depends on FB
        tristate "i915 driver"

I'm guessing that that "depends on FB" wants to be "select FB".

-- 
Eric Anholt
eric@...olt.net                         eric.anholt@...el.com



Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)