linux-kernel - Re: [patch 2/3] mm: hugetlb -- get rid of redundant if operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090102092221.GA1975@elte.hu>
Date:	Fri, 2 Jan 2009 10:22:21 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Cyrill Gorcunov <gorcunov@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	William Irwin <wli@...omorphy.com>
Subject: Re: [patch 2/3] mm: hugetlb -- get rid of redundant if operation


Andrew Cc:-ed.

patch looks correct to me.

Reviewed-by: Ingo Molnar <mingo@...e.hu>

	Ingo

* Cyrill Gorcunov <gorcunov@...il.com> wrote:

> At this point we already know that 'addr' is not NULL
> so get rid of redundant 'if'. Probably gcc eliminate it
> by optimization pass.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> CC: William Irwin <wli@...omorphy.com>
> ---
>  mm/hugetlb.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: linux-2.6.git/mm/hugetlb.c
> ===================================================================
> --- linux-2.6.git.orig/mm/hugetlb.c
> +++ linux-2.6.git/mm/hugetlb.c
> @@ -991,8 +991,7 @@ __attribute__((weak)) int alloc_bootmem_
>  			 * puts them into the mem_map).
>  			 */
>  			m = addr;
> -			if (m)
> -				goto found;
> +			goto found;
>  		}
>  		hstate_next_node(h);
>  		nr_nodes--;
> 
> -- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/