linux-kernel - Re: libusb broken on 2.6.28 x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <495DE060.8040707@rtr.ca>
Date:	Fri, 02 Jan 2009 04:37:36 -0500
From:	Mark Lord <lkml@....ca>
To:	Greg KH <gregkh@...e.de>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-usb@...r.kernel.org
Subject: Re: libusb broken on 2.6.28 x86_64 ?

Greg KH wrote:
..
> Hm, care to run 'git bisect'?
..

No, thanks.  But the number of USB core changes in 2.6.28 is rather small,
so I just ended up looking at each of them in more detail.

This patch, below, FIXES it for me, by undoing a change from 2.6.28.

Signed-off-by: Mark Lord <mlord@...ox.com>

--- old/drivers/usb/core/driver.c	2008-12-24 18:26:37.000000000 -0500
+++ linux/drivers/usb/core/driver.c	2009-01-02 04:34:11.000000000 -0500
@@ -279,9 +279,7 @@
 	 * altsetting means creating new endpoint device entries).
 	 * When either of these happens, defer the Set-Interface.
 	 */
-	if (intf->cur_altsetting->desc.bAlternateSetting == 0)
-		;	/* Already in altsetting 0 so skip Set-Interface */
-	else if (!error && intf->dev.power.status == DPM_ON)
+	if (!error && intf->dev.power.status == DPM_ON)
 		usb_set_interface(udev, intf->altsetting[0].
 				desc.bInterfaceNumber, 0);
 	else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/