linux-kernel - Re: [PATCH] Fix race in ring_buffer_consume(): Replace ring_buffer_consume and ring_buffer_peek with ring_buffer_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231026917.15476.0.camel@localhost.localdomain>
Date:	Sat, 03 Jan 2009 18:55:17 -0500
From:	Steven Rostedt <srostedt@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Indan Zupancic <indan@....nu>, Ingo Molnar <mingo@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix race in ring_buffer_consume(): Replace
	ring_buffer_consume and ring_buffer_peek with ring_buffer_get_event


On Fri, 2009-01-02 at 23:08 +0100, Ingo Molnar wrote:
> * Indan Zupancic <indan@....nu> wrote:
> 
> > On Mon, December 29, 2008 13:24, Ingo Molnar wrote:
> > >
> > > * Indan Zupancic <indan@....nu> wrote:
> > >
> > >> Original mail was mangled, patch resent via git.
> > >>
> > >> Signed-off-by: Indan Zupancic <indan@....nu>
> > >> ---
> > >>  include/linux/ring_buffer.h   |    4 +---
> > >>  kernel/trace/ring_buffer.c    |   39
> > >> ++++++++-------------------------------
> > >>  kernel/trace/trace.c          |   15 ++++++++-------
> > >>  kernel/trace/trace_selftest.c |    2 +-
> > >>  4 files changed, 18 insertions(+), 42 deletions(-)
> > >
> > > there's been a number of updates here - could you please do a patch
> > > against tip/master:
> > >
> > >   http://people.redhat.com/mingo/tip.git/README
> > 
> > Thanks for that readme, now I discovered git remote, which is not
> > mentioned often enough for some reason.
> > 
> > A lot changed indeed, most importantly the race that I hit is
> > fixed in tip by improved locking. Replace ring_buffer_consume()
> > and ring_buffer_peek() with ring_buffer_get_event() or not is
> > just a matter of taste now. Are you still interested in such a
> > patch?
> 
> the code gets simpler and more readable, so why not? Steve, any 
> objections?

I'd like to look closer at this code on Monday.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/