linux-kernel - Re: [PATCH] Add TI TSC2005 Touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d5443650901022038p310f77e3ifee241080126d9b1@mail.gmail.com>
Date:	Sat, 3 Jan 2009 10:08:03 +0530
From:	"Trilok Soni" <soni.trilok@...il.com>
To:	me@...ipebalbi.com
Cc:	"David Brownell" <david-b@...bell.net>, dmitry.torokhov@...il.com,
	"linux-omap@...r.kernel.org Mailing List" 
	<linux-omap@...r.kernel.org>, linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net,
	linux-input@...r.kernel.org, lauri.leukkunen@...ia.com
Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver

Hi Felip,

Sorry for the delayed reply.

On Mon, Dec 8, 2008 at 11:58 PM, Felipe Balbi <me@...ipebalbi.com> wrote:
> On Mon, Dec 08, 2008 at 11:19:53PM +0530, Trilok Soni wrote:
>> +static ssize_t tsc2005_disable_store(struct device *dev,
>> +                                  struct device_attribute *attr,
>> +                                  const char *buf, size_t count)
>> +{
>> +     struct tsc2005          *tsc = dev_get_drvdata(dev);
>> +     unsigned long res;
>> +     int i;
>> +
>> +     i = strict_strtoul(buf, 10, &res);
>> +     i = i ? 1 : 0;
>
> shouldn't this be i = res ? 1 : 0; ??

You are right, I will change this.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/