linux-kernel - Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090104231202.239c824a.sfr@canb.auug.org.au>
Date:	Sun, 4 Jan 2009 23:12:02 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Milton Miller <miltonm@....com>
Cc:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
	linux-ppc <linuxppc-dev@...abs.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with
 !CONFIG_VIOPATH

Hi Milton,

On Sun, 4 Jan 2009 02:54:15 -0600 Milton Miller <miltonm@....com> wrote:
>
> As VIOPATH is iSeries code and is only used by the iSeries code, the 
> requirment should be
> 
> depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
> 
> except VIOPATH isn't selectable:
> 
> arch/powerpc/platforms/iseries/Kconfig:
> 
>   config VIOPATH
>          bool
>          depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
>          default y
> 
> so instead we should be adding
> 
> select VIOPATH if PPC_ISERIES
> 
> to SCSI_IBMVSCSI and just
> 
> select VIOPATH
> 
> to HVC_ISERIES as it depends on PPC_ISERIES
> 
> otherwise you have to enable one driver to get these other drivers.

You are completely correct.  We didn't have "select" when those drivers
were added (at least I was not aware of it) so they should all be changed
to select VIOPATH and the dependency in VIOPATH should be dropped.  This sort of thing is exactly what select is for.
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped