linux-kernel - Re: swiotlb: remove duplicated #include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090104214109A.fujita.tomonori@lab.ntt.co.jp>
Date:	Sun, 4 Jan 2009 21:41:45 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	mingo@...e.hu
Cc:	fujita.tomonori@....ntt.co.jp, jeremy@...p.org,
	beckyb@...nel.crashing.org, jj@...osbits.net,
	weiyi.huang@...il.com, linux-kernel@...r.kernel.org
Subject: Re: swiotlb: remove duplicated #include

On Sun, 4 Jan 2009 13:19:14 +0100
Ingo Molnar <mingo@...e.hu> wrote:

> 
> * FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> wrote:
> 
> > On Sun, 4 Jan 2009 12:25:43 +0100
> > Ingo Molnar <mingo@...e.hu> wrote:
> > 
> > > 
> > > * Jesper Juhl <jj@...osbits.net> wrote:
> > > 
> > > > On Sun, 4 Jan 2009, Huang Weiyi wrote:
> > > > 
> > > > > Removed duplicated #include in lib/swiotlb.c.
> > > > > 
> > > > 
> > > > This is identical to a patch I already submitted - 
> > > > http://lkml.org/lkml/2009/1/2/360 - but I don't know if that one has been 
> > > > merged anywhere yet.
> > > 
> > > i've applied yours to tip/core/urgent, thanks Jesper!
> > 
> > The same cleanup is in tip/core/iommu:
> > 
> > http://marc.info/?l=linux-kernel&m=123044446721529&w=2
> 
> yes, correct - as part of Becky and Jeremy's highmem series.
> 
> > My cleanup patches in it are trivial, but I like to see Becky's swiotlb 
> > highmem work, which is still in tip/core/iommu. When do you plan to push 
> > it to mainline?
> 
> In a few days, but wanted to hear back from either Jeremy or Becky first 
> about how well they actually work in their usecases.

Well, you don't need to wait, I think.

All Jeremy and Becky need is adding highmem support to swiotlb. How we
support it doesn't matter. We can choose better one.

We all (including Jeremy) agreed that Becky's physical address scheme
is better (simpler) than Jeremy's struct page and offset
scheme. Surely, Becky's scheme works for Xen and him (Jeremy said that
he tested it lightly).

One remaining issue is how to support map_page/unmap_page. As we
discussed, we can add some workarounds for it but it's better to unify
dma_mapping_ops. I send patches to do it after testing them on an IA64
box tomorrow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/