linux-kernel - Re: [PATCH] firewire: cdev: fix documentation of FW_CDEV_IOC_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49600856.8030500@s5r6.in-berlin.de>
Date:	Sun, 04 Jan 2009 01:52:38 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: cdev: fix documentation of FW_CDEV_IOC_GET_INFO

I wrote:
> The FW_CDEV_IOC_GET_INFO ioctl looks at client->device->config_rom, not
> at the local node's config ROM.
> 
> We could fix the implementation or the documentation.  I believe the way
> how it is currently implemented is more useful than the way how it is
> currently documented, hence let's change only the documentation.
...
>   * struct fw_cdev_get_info - General purpose information ioctl
...
>   * @rom:	If non-zero, address of a buffer to be filled by a copy of the
> - *		local node's configuration ROM
> + *		device's configuration ROM

Of course libdc1394 uses the ABI already as implemented, not as documented.
-- 
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/