| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <3f9a31f40901040957g5a391408u5cda93c4acb66e9d@mail.gmail.com> Date: Sun, 4 Jan 2009 23:27:31 +0530 From: "Jaswinder Singh Rajput" <jaswinderlinux@...il.com> To: "Ingo Molnar" <mingo@...e.hu> Cc: "Jaswinder Singh Rajput" <jaswinder@...radead.org>, "x86 maintainers" <x86@...nel.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH -tip] x86: setup.c fix style problems On Sun, Jan 4, 2009 at 10:51 PM, Ingo Molnar <mingo@...e.hu> wrote: > > * Jaswinder Singh Rajput <jaswinder@...radead.org> wrote: > >> Impact: cleanup, fix style problems, more readable >> >> Fixes style problems: >> WARNING: Use #include <linux/smp.h> instead of <asm/smp.h> >> WARNING: Use #include <linux/percpu.h> instead of <asm/percpu.h> >> WARNING: Use #include <linux/topology.h> instead of <asm/topology.h> >> WARNING: externs should be avoided in .c files >> ERROR: code indent should use tabs where possible >> >> total: 2 errors, 4 warnings > > doesnt build on some configs: > > arch/x86/kernel/setup.c:943: error: implicit declaration of function 'prefill_possible_map' > This problem will only arise if CONFIG_SMP is not defined. Then linux/smp.h will not include asm/smp.h But why we are keeping non SMP stuff in asm/smp.h, we need to fix this. JSR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists