linux-kernel - Re: [PATCH 1/4] ufs: validate maximum fast symlink size from superblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090104191558.GA23805@rain>
Date:	Sun, 4 Jan 2009 22:15:59 +0300
From:	Evgeniy Dushistov <dushistov@...l.ru>
To:	Duane Griffin <duaneg@...da.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] ufs: validate maximum fast symlink size from
	superblock

On Wed, Dec 31, 2008 at 04:50:05PM +0000, Duane Griffin wrote:
> The maximum fast symlink size is set in the superblock of certain types
> of UFS filesystem. Before using it we need to check that it isn't longer
> than the available space we have in the inode.
> 
> Signed-off-by: Duane Griffin <duaneg@...da.com>
> ---
>  fs/ufs/super.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ufs/super.c b/fs/ufs/super.c
> +		printk(KERN_WARNING "ufs_read_super: excessive maximum fast "
> +		       "symlink size (%u)\n", uspi->s_maxsymlinklen);
> +		uspi->s_maxsymlinklen = maxsymlen;
> +	}
> +

Better and logically to use ufs_warning here, because of it show device id,
in case person has serveral ufs formated partitions and mount happened
during system boot time.

-- 
/Evgeniy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/