linux-kernel - Re: [PATCH] Make treercu safe for suspend and resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090105091249.GB5440@elte.hu>
Date:	Mon, 5 Jan 2009 10:12:50 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, dhaval@...ux.vnet.ibm.com,
	jens.axboe@...cle.com, snakebyte@....de, andi@...stfloor.org,
	akpm@...ux-foundation.org, dvhltc@...ibm.com, niv@...ibm.com,
	rostedt@...dmis.org, tglx@...utronix.de, manfred@...orfullife.com
Subject: Re: [PATCH] Make treercu safe for suspend and resume


* Paul E. McKenney <paulmck@...ux.vnet.ibm.com> wrote:

> Hello!
> 
> Kudos to both Dhaval Giani and Jens Axboe for finding a bug in treercu
> that causes warnings after suspend-resume cycles in Dhaval's case and
> during stress tests in Jens's case.  It would also probably cause failures
> if heavily stressed.  The solution, ironically enough, is to revert to
> rcupreempt's code for initializing the dynticks state.  And the patch
> even results in smaller code -- so what was I thinking???
> 
> This is 2.6.29 material, given that people really do suspend and resume
> Linux these days.  ;-)
> 
> Located-by: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
> Located-by: Jens Axboe <jens.axboe@...cle.com>
> Tested-by: Dhaval Giani <dhaval@...ux.vnet.ibm.com>
> Tested-by: Jens Axboe <jens.axboe@...cle.com>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> ---
> 
>  rcutree.c |   12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)

applied to tip/core/urgent, thanks guys!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/