linux-kernel - Re: [patch] document ext3 a bit better

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090105145713.GB4116@mit.edu>
Date:	Mon, 5 Jan 2009 09:57:13 -0500
From:	Theodore Tso <tytso@....edu>
To:	Pavel Machek <pavel@...e.cz>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>, mtk.manpages@...il.com,
	rdunlap@...otime.net, linux-doc@...r.kernel.org
Subject: Re: [patch] document ext3 a bit better

On Sun, Jan 04, 2009 at 11:34:33PM +0100, Pavel Machek wrote:
> @@ -14,6 +14,11 @@ Options
>  When mounting an ext3 filesystem, the following option are accepted:
>  (*) == default
>  
> +ro			Mount filesystem read only. Note that ext3 will replay
> +			the journal (and thus write to the partition) even when
> +			mounted "read only". "ro, noload" can be used to prevent
> +			writes to the filesystem.

I'd sugest "ro,noload" since the spaces screw up the mount options
parsing both on the command-line and in /etc/fstab.  So how about:

	Using the mount options "ro,noload" can be used....

> @@ -95,6 +102,8 @@ debug			Extra debugging information is s
>  errors=remount-ro(*)	Remount the filesystem read-only on an error.
>  errors=continue		Keep going on a filesystem error.
>  errors=panic		Panic and halt the machine if an error occurs.
> +			(Note that default is overriden by superblock
> +			setting on most systems).

The default is always specified by the superblock setting.  So users
will probably find it easier to understand if we remove the "(*)" and
to add the explanatory comment:

			(These mount options override the errors behavior
			specified in the superblock, which can be configured
			using tune2fs)

Pavel, thanks for working on improving the documentation; with these
fixes,

Signed-off-by: "Theodore Ts'o" <tytso@....edu>

							- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/