linux-kernel - Re: early exception error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090105153025.GH7645@localhost>
Date:	Mon, 5 Jan 2009 18:30:25 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Robert Hancock <hancockr@...w.ca>,
	linux-kernel@...r.kernel.org, david@...g.hm,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: early exception error

[Jiri Slaby - Mon, Jan 05, 2009 at 04:14:12PM +0100]
| On 01/05/2009 04:01 PM, Cyrill Gorcunov wrote:
| > [Jiri Slaby - Mon, Jan 05, 2009 at 03:51:26PM +0100]
| > | On 01/05/2009 02:08 PM, Andi Kleen wrote:
| > | > +#define EARLY_BUG_ON(x) do { if (unlikely(!(x))) EARLY_BUG(); } while (0)
| > | 
| > | I think unintentionally inverted logic.
| > 
| > just second ! is missed :)
| 
| None is needed, two '!' are added in the macro itself while it passes the
| parameter to the builtin.

ah, yep :)

| 
| > | 
| > | > +#define EARLY_BUG_ON(x) do {} while(0)
| > | 
| > | Shouldn't be x referenced here?
| > |
| > 
| > but for what?
| 
| I know, core devs are sane, but e.g. for reasons such as
| 
| {'a' is used here already}
| EARLY_BUG_ON(!(a = readl(...)))
| {use 'a' again}
| 
| to stay on the safe side.
| 

I wouldn't populate this style Jiri. It become more complicated
as it should to be, agreed?

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/