linux-kernel - Re: [PATCH] aerdrv: fix sanity check in report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200901051323.32341.jbarnes@virtuousgeek.org>
Date:	Mon, 5 Jan 2009 13:23:32 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	linux-pci@...r.kernel.org, tom.l.nguyen@...el.com,
	yanmin.zhang@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] aerdrv: fix sanity check in report_resume

On Monday, January 5, 2009 1:03 pm Jesse Barnes wrote:
> On Sunday, November 30, 2008 11:31 pm Hidetoshi Seto wrote:
> > What we have to check here before calling it is err_handler->resume.
> > It seems that this block have been copy&pasted from report_slot_reset.
> >
> > Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> > ---
> >  drivers/pci/pcie/aer/aerdrv_core.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/pci/pcie/aer/aerdrv_core.c
> > b/drivers/pci/pcie/aer/aerdrv_core.c index dfc63d0..aac7006 100644
> > --- a/drivers/pci/pcie/aer/aerdrv_core.c
> > +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> > @@ -252,7 +252,7 @@ static void report_resume(struct pci_dev *dev, void
> > *data)
> >
> >  	if (!dev->driver ||
> >  		!dev->driver->err_handler ||
> > -		!dev->driver->err_handler->slot_reset)
> > +		!dev->driver->err_handler->resume)
> >  		return;
> >
> >  	err_handler = dev->driver->err_handler;
>
> Applied (again).  Hope it doesn't get lost again between now & when I send
> the pull.  Sorry about that.

Ah nm, I see it went through my for-linus branch, so it appears to be upstream 
already.... Phew.  I'm still lossy but not as lossy as I thought I was. :)

-- 
Jesse Barnes, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/