linux-kernel - Re: [PATCH]USB:Fix goku

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200901051446.09047.david-b@pacbell.net>
Date:	Mon, 5 Jan 2009 14:46:08 -0800
From:	David Brownell <david-b@...bell.net>
To:	sangsu <sangsu@...il.com>
Cc:	linux-usb@...r.kernel.org, stern@...land.harvard.edu,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]USB:Fix goku_udc usb speed handling

On Thursday 01 January 2009, sangsu wrote:
> The usb gadget framework revealed weakness in the godu_udc
> gadget driver register function. Instead of checking if 
> speed asked for was USB_LOW_SPEED upon usb_gadget_register()
> to deny service, it checked only for USB_FULL_SPEED, thus
> denying service to usb high speed capable gadgets.
> 
> Signed-off-by: SangSu Park<sangsu@...il.com>

Acked-by: David Brownell <dbrownell@...rs.sourceforge.net>


Good to know this USB peripheral driver is getting some use.  :)


> ---
> drivers/usb/gadget/goku_udc.c |2+-
> 1 files changed, 1 insertion(+), 1 deletions(-)
> 
> 
> --- a/drivers/usb/gadget/goku_udc.c	2008-12-30 23:24:02.000000000 +0900
> +++ b/drivers/usb/gadget/goku_udc.c	2009-01-02 00:49:15.000000000 +0900
> @@ -1349,7 +1349,7 @@
>  	int			retval;
>  
>  	if (!driver
> -			|| driver->speed != USB_SPEED_FULL
> +			|| driver->speed < USB_SPEED_FULL
>  			|| !driver->bind
>  			|| !driver->disconnect
>  			|| !driver->setup)
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/