linux-kernel - Re: [PATCH] [3/5] Mark complex bitops.h inlines as __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090106101710.GA22134@elte.hu>
Date:	Tue, 6 Jan 2009 11:17:10 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	akpm@...ux-foundation.org, x86@...nel.org,
	linux-kernel@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] [3/5] Mark complex bitops.h inlines as __always_inline


* Andi Kleen <andi@...stfloor.org> wrote:

> Hugh Dickins noticed that older gcc versions when the kernel is built 
> for code size didn't inline some of the bitops.

Older GCCs have a whole lot more problems than suboptimal inlining 
decisions.

Your patch is wrong because it prevents a good compiler from doing the 
right inlining decisions.

So why should i apply this?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/