linux-kernel - Re: linux-next: Tree for January 6 (MTD)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0901061632590.4300@casper.infradead.org>
Date:	Tue, 6 Jan 2009 17:36:09 +0000 (GMT)
From:	Alexey Korolev <akorolev@...radead.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Vasiliy Leonenko <vasiliy.leonenko@...il.com>
Subject: Re: linux-next: Tree for January 6 (MTD)

Hi Randy,

> # CONFIG_MTD_LPDDR is not set
> CONFIG_MTD_QINFO_PROBE=y
> 
> There appears to be too little control/coordination between those
> two kconfig symbols.  Surely one of them (MTD_QINFO_PROBE) should
> depend on the other (MTD_LPDDR).  And why even build 2 modules
> when MTD_QINFO_PROBE is enabled?  Why not combine the code into
> one module?
Thanks a lot for good finding. Here is a fix for the problem.

About combining: it is assumed to have one QINFO probing module for several
kinds of LPDDR command set drivers. If we combine two modules into
one it would make further extension rather hard. So it is better to have
two modules.
To fix a problem I just added dependency in Kconfig file.
This temporary fix which will work until we have just one cmdset module.
In near future we will make a fix which parse command set types
 and select proper driver according to device type.

Thanks,
Alexey

Signed-off-by: Alexey Korolev <akorolev@...radead.org>
---
diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
index acd4ea9..5a401d8 100644
--- a/drivers/mtd/lpddr/Kconfig
+++ b/drivers/mtd/lpddr/Kconfig
@@ -12,6 +12,7 @@ config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/