linux-kernel - Re: [PATCH 03/23] cris: introduce asm/swab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231279452.25147.1.camel@brick>
Date:	Tue, 06 Jan 2009 14:04:12 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jesper Nilsson <jesper.nilsson@...s.com>
Subject: Re: [PATCH 03/23] cris: introduce asm/swab.h

On Tue, 2009-01-06 at 13:59 -0800, Linus Torvalds wrote:
> 
> On Tue, 6 Jan 2009, Harvey Harrison wrote:
> >
> > cris holds its arch overrides in an arch/ folder, rename these
> > byteorder.h files to swab.h and include them from asm/swab.h
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > ---
> >  arch/cris/include/arch-v10/arch/byteorder.h |   28 ---------------------------
> >  arch/cris/include/arch-v10/arch/swab.h      |   28 +++++++++++++++++++++++++++
> >  arch/cris/include/arch-v32/arch/byteorder.h |   22 ---------------------
> >  arch/cris/include/arch-v32/arch/swab.h      |   22 +++++++++++++++++++++
> 
> 
> Since you'e a git user, and you're basically renaming files while then 
> putting a new name in place, can you please send patches done with both 
> the "-M" flag (rename detection) _and_ the "-B" flag (which breaks 
> associations of files even if the name stays the same)?
> 
> It's rare that this is needed, but it really helps. Now the patches look 
> like a big delete/create event, and it's not at all obvious that the code 
> is actually the same before and after.

Sure, I sent regular patches as a courtesy to Andrew in case he slurped
it up, but I can resend with -M -B if you're going to take it directly,
should I wait until I see the remaining 4 arches hit your tree, or will
you worry about the timing?

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/