linux-kernel - Re: 2.6.29 -mm merge plans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090106150855.5f362a2d.akpm@linux-foundation.org>
Date:	Tue, 6 Jan 2009 15:08:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	linux-kernel@...r.kernel.org,
	Dmitri Monakhov <dmonakhov@...nvz.org>
Subject: Re: 2.6.29 -mm merge plans

(cc added)

On Tue, 6 Jan 2009 17:57:44 -0500
Christoph Hellwig <hch@...radead.org> wrote:

> On Mon, Jan 05, 2009 at 12:43:00AM -0800, Andrew Morton wrote:
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error.patch
> > fs-truncate-blocks-outside-i_size-after-o_direct-write-error-fix.patch
> 
> Btw, this code is still not quite right.  We really need to call
> ->setattr instead of vmtruncate here.  Complex filesystem need
> transaction to properly free blocks, and those transactions are in
> ->setattr not inside vmtruncate where ->truncate doesn't even have
> a chance to get the handle to the transaction passed.
> 
> As these patches don't make it worse this is not a NACK, but more of
> a heads up.

Sure.  Maybe add a FIXME comment for now?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/