linux-kernel - Re: 2.6.29 -mm merge plans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1231285773.1529.4.camel@brick>
Date:	Tue, 06 Jan 2009 15:49:33 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	"Diego E. 'Flameeyes' Petten?" <flameeyes@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Warren Turkal <wt@...guintechs.org>,
	Roman Zippel <zippel@...ux-m68k.org>
Subject: Re: 2.6.29 -mm merge plans

On Tue, 2009-01-06 at 18:31 -0500, Christoph Hellwig wrote:
> Yes, the version you attached looks much better, and correct.
> 
> Just some minor comments:
> 
> > +++ b/fs/hfsplus/export.c
> > @@ -0,0 +1,118 @@
> > +/*
> > + *  linux/fs/hfsplus/export.c
> > + *
> 
> Please don't put filenames in top of file comments.  They don't serve
> any purpose and easily get out of date.
> 
> > +	if ( be16_to_cpu(entry.type) != HFSPLUS_FOLDER_THREAD) {
> 
> no space after the opening brace, please/

One other nit, byteswap the constant so it can be done at compile-time:

	if (entry.type != cpu_to_be16(HFSPLUS_FOLDER_THREAD)) {

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/