linux-kernel - Re: [git pull] device-mapper patches for 2.6.29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91b13c310901051915i38e05125tb89b3335922d274e@mail.gmail.com>
Date:	Tue, 6 Jan 2009 11:15:58 +0800
From:	"Cheng Renquan (程任全)" 
	<crquan@...il.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	"Alasdair G Kergon" <agk@...hat.com>, dm-devel@...hat.com,
	linux-kernel@...r.kernel.org,
	"Jonathan Brassow" <jbrassow@...hat.com>,
	"Mikulas Patocka" <mpatocka@...hat.com>,
	"Milan Broz" <mbroz@...hat.com>, "Andi Kleen" <ak@...e.de>,
	"Jun'ichi Nomura" <j-nomura@...jp.nec.com>,
	"Kiyoshi Ueda" <k-ueda@...jp.nec.com>,
	"Takahiro Yasui" <tyasui@...hat.com>
Subject: Re: [git pull] device-mapper patches for 2.6.29

2009/1/6 Linus Torvalds <torvalds@...ux-foundation.org>:
>
>
> On Mon, 5 Jan 2009, Alasdair G Kergon wrote:
>>
>> Please pull from:
>>
>>   master.kernel.org:/pub/scm/linux/kernel/git/agk/linux-2.6-dm.git
>>
>> to get the following device-mapper patches for 2.6.29:
>
> Oh no, this is totally broken, and doesn't compile even with my fairly
> minimal install:
>
>  drivers/md/dm-target.c: In function 'dm_unregister_target':
>  drivers/md/dm-target.c:106: error: implicit declaration of function 'module_refcount'
>
> Not pulled.
>
>                Linus
>

That's my fault, module_refcount can only be used if
CONFIG_MODULE_UNLOAD defined according to <linux/module.h>,

So now maybe we can add a null macro to module_refcount if
CONFIG_MODULE_UNLOAD undefined?

-- 
Cheng Renquan (程任全), Shenzhen, China
Paula Poundstone  - "I don't have a bank account because I don't know
my mother's maiden name."