linux-kernel - Re: powerpc: introduce asm/swab.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090107053913.GA21687@goodmis.org>
Date:	Wed, 7 Jan 2009 00:39:13 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Harvey Harrison <harvey.harrison@...il.com>
Subject: Re: powerpc: introduce asm/swab.h

On Tue, Jan 06, 2009 at 09:11:42PM -0800, Linus Torvalds wrote:
> 
> 
> On Wed, 7 Jan 2009, Benjamin Herrenschmidt wrote:
> > 
> > Even if fixing that to use __swab32() instead, then it fails because
> > this is defined after it's used. I worked around it using fswab in
> > there instead.
> 
> That's the same patch I just sent out (but you changed comments too), so I 
> obviously agree. 
> 
> x86 didn't see this (even in 32-bit mode) because it doesn't use that odd 
> __SWAB_64_THRU_32__ case, but does the 64-bit swab with native code.
> 
> Can you also verify that it works for you (not just compiles), just so 
> that I can commit it?

I'm the one that originally told Ben about this breaking the PPC32 build.
His patch compiles on my PPC32 box. I just rebooted with the new kernel
and it boots.

Tested-by: Steven Rostedt <srostedt@...hat.com>

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/