| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1231319784-18695-4-git-send-email-swhiteho@redhat.com> Date: Wed, 7 Jan 2009 09:16:24 +0000 From: Steven Whitehouse <swhiteho@...hat.com> To: linux-kernel@...r.kernel.org, cluster-devel@...hat.com Cc: Benjamin Marzinski <bmarzins@...hat.com>, Steven Whitehouse <swhiteho@...hat.com> Subject: [PATCH 3/3] GFS2: Fix typo in gfs_page_mkwrite() From: Benjamin Marzinski <bmarzins@...hat.com> There is a typo in gfs2_page_mkwrite() gfs2_write_alloc_required() expects pos to be the offset in bytes. However, instead of the page index being shifted by by PAGE_CACHE_SHIFT, it was shifted by (PAGE_CACHE_SIZE - inode->i_blkbits). This patch simply shifts the page index by the proper amount. Signed-off-by: Benjamin Marzinski <bmarzins@...hat.com> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com> diff --git a/fs/gfs2/ops_file.c b/fs/gfs2/ops_file.c index 289c5f5..93fe41b 100644 --- a/fs/gfs2/ops_file.c +++ b/fs/gfs2/ops_file.c @@ -342,7 +342,7 @@ static int gfs2_page_mkwrite(struct vm_area_struct *vma, struct page *page) struct gfs2_inode *ip = GFS2_I(inode); struct gfs2_sbd *sdp = GFS2_SB(inode); unsigned long last_index; - u64 pos = page->index << (PAGE_CACHE_SIZE - inode->i_blkbits); + u64 pos = page->index << PAGE_CACHE_SHIFT; unsigned int data_blocks, ind_blocks, rblocks; int alloc_required = 0; struct gfs2_holder gh; -- 1.6.0.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists