linux-kernel - Re: [PATCH] sched: fix double kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 07 Jan 2009 09:19:23 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Mike Travis <travis@....com>
CC:	Ingo Molnar <mingo@...e.hu>, Rusty Russell <rusty@...tcorp.com.au>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched: fix double kfree

> Another thing I noticed but didn't deal with is:
> 
> static int init_rootdomain(struct root_domain *rd, bool bootmem)
> {
>         memset(rd, 0, sizeof(*rd));
> 
>         if (bootmem) {
>                 alloc_bootmem_cpumask_var(&def_root_domain.span);
>                 alloc_bootmem_cpumask_var(&def_root_domain.online);
>                 alloc_bootmem_cpumask_var(&def_root_domain.rto_mask);
>                 cpupri_init(&rd->cpupri, true);
>                 return 0;
>         }
>         if (!alloc_cpumask_var(&rd->span, GFP_KERNEL))
> 		...
> 
> Note that under the if (bootmem) case, it specifies the addresses
> directly instead of using (&rd->span) as the other alloc's do.
> 
> Not a big deal, just an inconsistency.
> 

I didn't notice this. :)

What makes it a bit worse is another inconsistency in if(bootmem), that rd
is used in cpupri_init() but def_root_domain is used in alloc()s.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/